xenapi: image downloading code requires unnecessary instance argument

Bug #1307662 reported by Christopher Lefelhocz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Christopher Lefelhocz

Bug Description

The downloading code in xenserver requires an instance argument. However in practice this argument is not used for debugging or any other purpose. Downloading in fact can occur without an instance being involved at all. We should remove this unused argument.

This is in preparation to separate out the download code and leverage it for precaching blueprint work. This should be treated as a bug on it's own as it's a code refactor/cleanup work.

Tags: xenserver
Changed in nova:
status: New → In Progress
assignee: nobody → Christopher Lefelhocz (christopher-lefelhoc)
tags: added: xenserver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/87356

Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/87356
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f9dfb5b25c087b5146e0c6a9956b2402aec6458f
Submitter: Jenkins
Branch: master

commit f9dfb5b25c087b5146e0c6a9956b2402aec6458f
Author: Christopher Lefelhocz <email address hidden>
Date: Sat Apr 12 03:52:14 2014 -0500

    XenAPI: Remove unneeded instance argument from image downloading

    The Xenapi image downloading code requires an instance argument
    when launching a VM. However, the downloading code doesn't
    need the instance information as it doesn't use it for
    any processing/debugging/loging. We can remove this
    argument safely.

    Change-Id: Id8b531b74e5f0e59638b608bff93fc89b66b889d
    Closes-bug: #1307662

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.