quota-defaults lists info with wrong tenant-id

Bug #1307486 reported by Tushar Bankar
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Low
Wenjun Wang

Bug Description

cinder quota-defaults wrong-tenantid

cinder returns with 200 Ok with list of quota.

But it is expected 404 Not Found

Tags: api quotas
Changed in cinder:
assignee: nobody → Tushar Bankar (tushar-bankar)
tags: added: izeltech
Revision history for this message
Tushar Bankar (tushar-bankar) wrote :

Response:

cinder quota-defaults wrong-tenantid
+-----------+-------+
| Property | Value |
+-----------+-------+
| gigabytes | 1000 |
| snapshots | 10 |
| volumes | 10 |
+-----------+-------+

Revision history for this message
Jay Bryant (jsbryant) wrote :

A while back I added code that populated the database with default values for the quotas to avoid numerous errors in the logs. I am wonder if this is related to this change.

I vaguely remember the code path having a default that it would go down if it couldn't find anything configured for a tenat. If time permits I will try to find where I saw that.

Changed in cinder:
importance: Undecided → Low
status: New → Triaged
Changed in cinder:
assignee: Tushar Bankar (tushar-bankar) → Harshada Mangesh Kakad (harshada-kakad)
Mike Perez (thingee)
Changed in cinder:
milestone: none → juno-1
tags: added: icehouse-backport-potential
removed: izeltech
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94340

Changed in cinder:
status: Triaged → In Progress
Changed in cinder:
milestone: juno-1 → juno-2
Revision history for this message
John Griffith (john-griffith) wrote :

<jdg>
Submitter seems to have lost interest at jenkins test failures :(

Changed in cinder:
milestone: juno-2 → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/94340
Reason: Abandoning change: No update for more than 14 days

Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → juno-rc1
Revision history for this message
John Griffith (john-griffith) wrote :

This isn't a blocker for RC as far as I'm concerned and shouldn't have been targeted.

Changed in cinder:
milestone: juno-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139610

Changed in cinder:
assignee: Harshada Mangesh Kakad (harshada-kakad) → Rushi Agrawal (rushiagr)
Mike Perez (thingee)
tags: removed: icehouse-backport-potential
Changed in cinder:
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/139610
Reason: Over a month with no update.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Owner Expired

Unassigning due to no activity.

Changed in cinder:
assignee: Rushi Agrawal (rushiagr) → nobody
Wenjun Wang (wangwenjun)
Changed in cinder:
assignee: nobody → Wenjun Wang (wangwenjun)
status: Incomplete → In Progress
Revision history for this message
Wenjun Wang (wangwenjun) wrote :

I think only admin user can get the default values of quota will be better,and I will add a parameter in "policy.json" to set the role who can obtain these values,like this:
"volume_extension:quotas:defaults": "role:admin",

the tenant id is not need any more,I want to remove the parameter "id" both in cinder and cinderclient.

Thanks for any suggestions.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294895

Revision history for this message
Wenjun Wang (wangwenjun) wrote :

we must get all tenants' id if we want to fix this bug without interface changes,

so there are two ways I can give:
1.remove the parameter tenant-id when get the default quota
2.get tenant-id from keystone

I think the second way is better as Ryan McNair's words in https://review.openstack.org/294895
it's very nice for any of your suggestions.

Tom Barron (tpb)
tags: added: quotas
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/294895
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.