Unnecessary qpid authentication details in the ML2 configuration page for the controller node

[Jeff Shantz]

Step 3 provides the following instructions for configuring Neutron on the controller node to use the message broker:

# openstack-config --set /etc/neutron/neutron.conf DEFAULT \
  rpc_backend neutron.openstack.common.rpc.impl_qpid
# openstack-config --set /etc/neutron/neutron.conf DEFAULT \
  qpid_hostname controller
# openstack-config --set /etc/neutron/neutron.conf DEFAULT \
  qpid_port 5672
# openstack-config --set /etc/neutron/neutron.conf DEFAULT \
  qpid_username guest
# openstack-config --set /etc/neutron/neutron.conf DEFAULT \
  qpid_password guest

First, the default qpid port is 5672, so configuring the port is unnecessary and inconsistent with previous qpid configuration steps. For instance, the qpid configuration in Chapter 6 for the compute node is given as:

# openstack-config --set /etc/nova/nova.conf \
  DEFAULT rpc_backend nova.openstack.common.rpc.impl_qpid
# openstack-config --set /etc/nova/nova.conf DEFAULT qpid_hostname controller

(http://docs.openstack.org/trunk/install-guide/install/yum/content/neutron-ml2-controller-node.html)

Second, no authentication was configured for the message broker, so the qpid_username and qpid_password entries will presumably cause an authentication failure (unless there is an pre-defined qpid 'guest' account of which I'm not aware -- I am not a qpid expert). Either way, it's unnecessary, and, once again, is inconsistent with previous qpid configuration steps in the documentation. In Chapter 2, qpid authentication is disabled: http://docs.openstack.org/trunk/install-guide/install/yum/content/basics-queue.html

-----------------------------------
Built: 2014-04-14T02:47:47 00:00
git SHA: 8099195aa242059be10781548303eb76cdd39f75
URL: http://docs.openstack.org/trunk/install-guide/install/yum/content/neutron-ml2-controller-node.html
source File: file:/home/jenkins/workspace/openstack-install-deploy-guide-fedora/doc/install-guide/section_neutron-ml2-controller-node.xml
xml:id: neutron-ml2-controller-node

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/87158

[Jeff Shantz (jeffshantz)]

I should note that I have double-checked that the neutron-server service connects successfully to the qpid server without the port and authentication details:

/var/log/neutron/server.log:

2014-04-14 06:05:12.884 2999 INFO neutron.openstack.common.rpc.impl_qpid [-] Connected to AMQP server on controller:5672

With that said, these settings do not prevent the server from establishing a connection to qpid. Still, I would argue it's better to stay consistent with the previous qpid configuration steps, none of which specify the port or authentication details:

http://docs.openstack.org/trunk/install-guide/install/yum/content/glance-install.html
http://docs.openstack.org/trunk/install-guide/install/yum/content/nova-controller.html
http://docs.openstack.org/trunk/install-guide/install/yum/content/nova-compute.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/87158
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=03d2079ba3ac09852324192ba667e582f73b7d8a
Submitter: Jenkins
Branch: master

commit 03d2079ba3ac09852324192ba667e582f73b7d8a
Author: Jeff Shantz <email address hidden>
Date: Sun Apr 13 23:38:29 2014 -0400

    Remove qpid port and authentication details

    Port 5672 is the default qpid port, and therefore does not need to be
    specified (it is also inconsistent with previous qpid configuration
    steps, which do not specify a port). Additionally, no authentication
    was configured for qpid in the documentation, so the authentication
    details should be removed.

    Change-Id: Ib2f66cf9deb472ee5eef8e7785eed8ef78fa815d
    Closes-Bug: #1307284

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.