apiclient.exceptions.from_response() may miss request_id

[Chris Buccella]

On error, the python clients can output useful debugging information, including the request ID of the response. This value can be searched for in the logs, and is useful for debugging.

Currently, apiclient.exceptions.from_response() gets the request_id from the value of the x-compute-request-id header. However, the common name for this header across OpenStack services is x-openstack-request-id; only nova and cinder use x-compute-request-id. So for glanceclient and other clients, the request ID value will not be present in error output, which hinders debugging efforts.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/86922

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/86922
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=3fb053c83036f90d2da3983cf6ab8f2981f17751
Submitter: Jenkins
Branch: master

commit 3fb053c83036f90d2da3983cf6ab8f2981f17751
Author: Chris Buccella <email address hidden>
Date: Fri Apr 11 14:42:36 2014 +0000

    apiclient.exceptions.from_response() may miss request_id

    The common header name for the request ID value across OpenStack projects is
    x-openstack-request-id. However, apiclient.exceptions.from_response() checks
    for x-compute-request-id, which is only set in nova and cinder responses.
    This precludes the request ID value from being outputted by glanceclient and
    others; this hinders error debugging.

    Change-Id: Ibb88d5e6a22c7422315dffd7c5853a29864e34d9
    Closes-Bug: #1306654