dhcp request doesn't provide client architecture code 93

[Blake Rouse]

Using qemu-system-ppc64 for netbooting fails to provide the dhcp option 93 (client architecture). This is used to to tell the netbooting machine the correct filename to request for the boot loader.

Command:
qemu-system-ppc64 -enable-kvm -M pseries -cpu host -smp cores=1,threads=1 -m 4G -net nic,macaddr=DE:AD:BE:EF:01:02 -net tap,script=no,downscript=no,ifname=tap0102 -device spapr-vscsi -drive file=/tmp/grub-start.6jPp7l/disk1.img -boot order=nc -nographic -vga none

Output:
SLOF **********************************************************************
QEMU Starting
 Build Date = Mar 5 2014 22:12:46
 FW Version = mockbuild@ release 20140304
 Press "s" to enter Open Firmware.

Populating /vdevice methods
Populating /vdevice/vty@71000000
Populating /vdevice/nvram@71000001
Populating /vdevice/l-lan@71000002
Populating /vdevice/v-scsi@71000003
       SCSI: Looking for devices
          8000000000000000 DISK : "QEMU QEMU HARDDISK 1.6."
          8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 1.6."
Populating /vdevice/v-scsi@71000004
       SCSI: Looking for devices
Populating /pci@800000020000000
 Adapters on 0800000020000000
                     None
No NVRAM common partition, re-initializing...
Scanning USB
Using default console: /vdevice/vty@71000000

  Welcome to Open Firmware

  Copyright (c) 2004, 2011 IBM Corporation All rights reserved.
  This program and the accompanying materials are made available
  under the terms of the BSD License available at
  http://www.opensource.org/licenses/bsd-license.php

Trying to load: from: net ...
 Bootloader 1.6
  Reading MAC address from device: DE:AD:BE:EF:01:02
  Requesting IP address via DHCP: 10.245.70.103
  Requesting file "pxelinux.0" via TFTP from 10.245.71.1
  Receiving data: 26 KBytes
  TFTP: Received pxelinux.0 (26 KBytes)

E3403: Bad executable:

E3406: Client application returned an error.

[Blake Rouse (blake-rouse)]

This is the capture of the DHCP request made by slof. No code 93 option is present.

[Murilo Opsfelder Araújo (mopsfelder)]

My patch was accepted upstream and it seems to fix this issue.

https://github.com/aik/SLOF/commit/db35f1b8a2d3e44f4a12ca926359cc2575e98064

commit db35f1b8a2d3e44f4a12ca926359cc2575e98064
Author: Murilo Opsfelder Araujo <email address hidden>
Date: Fri Jun 23 09:23:25 2017 -0300

    lib/Makefile: Pass FLAG to make in SUBDIRS target

    Some applications, e.g. https://maas.io/, trust on the dhcp code 93
    option to reply the correct pxelinux.0 file according to client
    architecture.

    Today, dhcp.c is compiled without DHCPARCH, which causes it not to
    send client architecture in the dhcp request, i.e. dhcpd server can
    reply a pxelinux.0 binary that is not intended for client
    architecture.

    This patch makes sure client architecture is sent in the dhcp request.

    Signed-off-by: Murilo Opsfelder Araujo <email address hidden>
    Signed-off-by: Alexey Kardashevskiy <email address hidden>