Deprecate old flanger and filter

[Owen Williams]

We shouldn't expose the old flanger and filter any more. Preferably I think we should remove the COs completely.

(this is a problem now if the user is in midi learn mode and clicks the flanger in the Mixxx UI)

[Max Linke (max-linke)]

This would also break compatibility to old midi-mappings. I'm not sure
how backwards compatibility looks right now with midi-mappings but I
thought it was the same like with the config/database. There an new
config version will also work with an old version of mixxx.

On Thu, 2014-04-10 at 19:11 +0000, Owen Williams wrote:
> Public bug reported:
>
> We shouldn't expose the old flanger and filter any more. Preferably I
> think we should remove the COs completely.
>
> (this is a problem now if the user is in midi learn mode and clicks the
> flanger in the Mixxx UI)
>
> ** Affects: mixxx
> Importance: Undecided
> Status: New
>

[Daniel Schürmann (daschuer)]

Flanger and Filter CO are already removed. So it does not make sense to allow to map them.
Probably, we will reintroduce a dedicated filter knob, if we move the EQ to the effect domain. But this is a 1.13 issue.

[Owen Williams (ywwg)]

In my midi learn PR, I added an error message if the user tries to map a deprecated control.

[Max Linke (max-linke)]

Owen is this fixed for you with the midi-learn changes? I'm good if we warn a user that he is mapping deprecated controls.

[Owen Williams (ywwg)]

yes the warning works.

[Owen Williams (ywwg)]

The next step of this bug is to remove these COs from any skin we ship with 1.12 -- so I will leave it open.

[RJ Skerry-Ryan (rryan)]

The COs aren't in our 3 skins so I think we can call it fixed now.

[jus (jus)]

So all "[ChannelN],filter$" controls can safely move to the Deprecated controls section in http://www.mixxx.org/wiki/doku.php/mixxxcontrols

We should document which new controls have to be used instead In order to achieve this functionality.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7412