OpenStack Dashboard (Horizon)

In ToggleSuspend, return False if instance is None

Bug #1306216 reported by Gabriel Luong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Gabriel Luong
OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

In openstack_dashboard/dashboards/project/instances/tables.py#ToggleSuspend/allowed(), the function does not return False when an instance is None. This should be aligned with TogglePause.

Gabriel Luong (gabriel-luong)
Changed in horizon:
assignee: nobody → Gabriel Luong (gabriel-luong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86678

Changed in horizon:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/86678
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0e4de67633bf1a480adca849093cf9d081d84d86
Submitter: Jenkins
Branch: master

commit 0e4de67633bf1a480adca849093cf9d081d84d86
Author: Gabriel Luong <email address hidden>
Date: Thu Apr 10 14:30:42 2014 -0400

    Return False if instance is None in TogglePause and ToggleSuspend

    Change-Id: Iad67cc61954f57c4260467d3f827a51b932b74b9
    Closes-Bug: #1306216

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.