parted use not well tested

Bug #1306153 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Dmitry Tantsur

Bug Description

PXE driver is now using parted for creating the partition table, and parted can be run against a flat file as though it were a disk, so we should test some edge cases:

- the cross product of 0, 1, 5 (in whatever unit) for each of (swap, root, ephemeral)
- corner case for sum(swap, root, ephemeral) = reported size of disk
- partitioning a disk with a bad but non-null partition table
- partition a disk, don't erase the partition table, and just partition it again with a differently sized root partition

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
Dmitry Tantsur (divius)
Changed in ironic:
assignee: nobody → Dmitry "Divius" Tantsur (divius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94620

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
Dmitry Tantsur (divius) wrote :

@devananda, what did you mean by "bad" in "partitioning a disk with a bad but non-null partition table"?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/94620
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fc7dfcc543d2517746c66927536ef78846f45b26
Submitter: Jenkins
Branch: master

commit fc7dfcc543d2517746c66927536ef78846f45b26
Author: Dmitry Tantsur <email address hidden>
Date: Wed May 21 15:46:05 2014 +0200

    Add some real-world testing on DiskPartitioner

    This patch adds some integration tests for DiskPartitioner by using
    it on a temporary file. As a side effect, this patch adds
    disk_partitioner.list_partitions() helper, which is used by the test,
    but can by used for anything else later.

    The new tests are currently skipped on gate-ironic-python26, as
    there is no `parted` utility there.
    Also these tests do not cover destroy_disk_metadata, as it can't
    be executed on a file.

    Change-Id: I53bf2d207b7d15a0673be6a6786c47500b9eb499
    Closes-Bug: #1306153

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.