if initial slow-sync fails, next attempt should re-run slow-sync
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
sync-monitor |
Fix Released
|
Critical
|
Unassigned | ||
sync-monitor (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The reason this is needed is that if the user disabled the account during a slow sync (like if it's taking too long, or they change their mind), or if the slow-sync fails, when it's re-enabled again we get a message that two/way sync failed because it thinks it has completed a slow sync already.
Perhaps the rule should be this:
1) run the slow-sync only once
-- if the slow sync fails for some reason (error, or account disabled), then next sync should retry the slow sync again.
2) if the slow-sync has ever been successful, then all other syncs should be two/way sync
3) if a two/way sync fails, next sync should be a two/way sync and not a slow sync (I think it works this way now). As long as one slow sync has been successful all other syncs should be two/way
4) maybe, if we disable and then renable the account, we always reset to run the slow sync. Not sure if this is necessary but might be a good way to reset the account if there are problems.
Related branches
- Bill Filler (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 422 lines (+116/-59)7 files modifiedsrc/main.cpp (+6/-0)
src/sync-account.cpp (+56/-33)
src/sync-account.h (+6/-3)
src/sync-configure.cpp (+39/-16)
src/sync-configure.h (+7/-5)
src/syncevolution-session-proxy.cpp (+1/-1)
src/syncevolution-session-proxy.h (+1/-1)
Changed in sync-monitor: | |
importance: | Undecided → Critical |
Changed in sync-monitor: | |
status: | New → In Progress |
Changed in sync-monitor: | |
status: | In Progress → Fix Released |
This bug was fixed in the package sync-monitor - 0.1+14. 04.20140415. 3-0ubuntu1
--------------- 04.20140415. 3-0ubuntu1) trusty; urgency=low
sync-monitor (0.1+14.
[ Renato Araujo Oliveira Filho ]
* Force sync to start immediately if use dbus call. (LP: #1306070)
* Keep a collection cache to compare with changed events. (LP:
#1306112)
* If the sync fails use the last sync mode in the next sync. (LP:
#1306096)
-- Ubuntu daily release <email address hidden> Tue, 15 Apr 2014 22:20:51 +0000