[compute] if images_type is lvm, there's no way to set libvirt_lvm_snapshot_size

Bug #1305120 reported by Stephan Renatus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Medium
Stephan Renatus

Bug Description

When introducing the possibility to change the libvirt_images_type, the following option was forgotten (by the bug reporter).

```
# The amount of storage (in megabytes) to allocate for LVM
# snapshot copy-on-write blocks. (integer value)
#libvirt_lvm_snapshot_size=1000
```

https://github.com/openstack/nova/blob/stable/havana/etc/nova/nova.conf.sample#L2079-L2081

Revision history for this message
Stephan Renatus (s-renatus) wrote :

I will propose a change to stable/havana in a minute, but this should probably also be fixed in this process: https://bugs.launchpad.net/openstack-chef/+bug/1266456

Changed in openstack-chef:
assignee: nobody → Stephan Renatus (s-renatus)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-compute (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/86362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-compute (stable/havana)

Reviewed: https://review.openstack.org/86362
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-compute/commit/?id=e4064623b032f44284918f4ab5e892431b31b49d
Submitter: Jenkins
Branch: stable/havana

commit e4064623b032f44284918f4ab5e892431b31b49d
Author: Stephan Renatus <email address hidden>
Date: Wed Apr 9 17:06:13 2014 +0200

    Allow configuring lvm_snapshot_size for lvm images_type

    This change allows changing the value used in `lvcreate` when
    snapshotting an instance (`nova image-create`).

    Change-Id: I39c4e781eaa08dcf686e40391a9ab15285743a58
    Closes-Bug: #1305120

tags: added: in-stable-havana
Revision history for this message
Stephan Renatus (s-renatus) wrote :

The master branch is not affected by this, since [the way snapshots are created has changed|https://github.com/openstack/nova/blob/stable/icehouse/nova/virt/libvirt/imagebackend.py#L452-L491].

Hence I'll close the bug.

Changed in openstack-chef:
status: New → Fix Released
Changed in openstack-chef:
milestone: none → icehouse-rc1
importance: Undecided → Medium
Changed in openstack-chef:
milestone: icehouse-rc1 → icehouse-stable
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.