Fuel CLI UX doesn't meet user expectation

[Ivan Kolodyazhny]

Steps to reproduce:

1. Create env from CLI:
[root@fuel ~]# fuel environment create --name test --rel 1
Environment 'test' with id=2, mode=ha_compact and network-mode=nova_network was created!

2. View it:
[root@fuel ~]# fuel environment list
id | status | name | mode | release_id | changes
---|--------|------|------------|------------|---------------------------------------------------------------------------------------
2 | new | test | ha_compact | 1 | [{u'node_id': None, u'name': u'attributes'}, {u'node_id': None, u'name': u'networks'}]

At this point looks like a cluster has changes and is ready to deploy

3. Try to deploy cluster:
[root@fuel ~]# fuel deploy-changes --env 2
HTTP Error 500: Internal Server Error (internal server error)

From /var/log/nailgun/app.log:
2014-04-09 10:42:19.710 ERROR [7fac0ebfd700] (base) Error during execution of deployment task on environment '2': No changes to deploy

Expected results:
1. User should not see changes for just created cluster
2. Server error should be handled and correct error message displayed.

[Alexandr Notchenko (anotchenko)]

This bug has nothing to do with Fuel CLI UX. Fuel-client only displays the error that it received from nailgun. It's a nailgun problem of incorrect error message.

[Dmitry Pyzhov (dpyzhov)]

It should be fixed in nailgun. Just fix "Error 500" and return meaningful error message.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/87289

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/87289
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7ed1e01cf4a72f1861784cc06b931e258567174a
Submitter: Jenkins
Branch: master

commit 7ed1e01cf4a72f1861784cc06b931e258567174a
Author: Alexandr Notchenko <email address hidden>
Date: Mon Apr 14 18:58:54 2014 +0400

    Fixing error on deployment without nodes

     * Exception handling in handlers/base.py
     * Added test for that error

     Closes-bug: #1304991

    Change-Id: Idb9652dea46f5bdb054c378f687f5cfc359da02e

[Egor Kotko (ykotko)]

Checked on:
{"build_id": "2014-05-16_01-10-31", "mirantis": "yes", "build_number": "208", "ostf_sha": "353f918197ec53a00127fd28b9151f248a2a2d30", "nailgun_sha": "89e7224f0b87284f75bf02b956b640768fabe352", "production": "docker", "api": "1.0", "fuelmain_sha": "861f4410bd07ecf40c1f87785dd0c86de387f2cf", "astute_sha": "c0418e1739cceb864fd2c548a7c6b9ad6a46ed86", "release": "5.0", "fuellib_sha": "68ef90fdc9fe5a3978f756a96a3fa29d5f1a2929"}