VMware: fakes.py should be moved to the tests directory

Bug #1304917 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Gary Kotton

Bug Description

The file nova/virt/vmwareapi/fake.py should be moved to the tests directory. This is solely used in the unit tests. There is no need for this to reside in the virt directory.

Tags: vmware
Gary Kotton (garyk)
Changed in nova:
importance: Undecided → Wishlist
milestone: none → juno-1
assignee: nobody → Gary Kotton (garyk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86257

Changed in nova:
status: New → In Progress
Revision history for this message
Gary Kotton (garyk) wrote :
tags: added: vmware
Revision history for this message
John Garbutt (johngarbutt) wrote :

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

Changed in nova:
milestone: juno-1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/86257
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5aa4331cc8d9c0e4615f9859395a9ae8c6d40f09
Submitter: Jenkins
Branch: master

commit 5aa4331cc8d9c0e4615f9859395a9ae8c6d40f09
Author: Gary Kotton <email address hidden>
Date: Wed Apr 9 01:52:02 2014 -0700

    VMware: move fake.py to the test directory

    The file fake.py (contains the simulated VC/ESX API's) should
    reside in the test directory.

    TrivialFix

    Change-Id: Ifd82c2f4375dd5e60ee4754fad7810d4e6ccf6d4
    Closes-bug: #1304917

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.