Change NetworkName to NetworkId across codebase and use network tags in the API
Bug #1304905 reported by
Dimiter Naydenov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-core |
Fix Released
|
Critical
|
Dimiter Naydenov | ||
Bug Description
We need to make a clear distinction between how juju refers to networks (juju-specific ids) and how the provider does (like the difference between machineId and instanceId). We also need to change the API to work with network tags rather than names (i.e. "network-
This needs to be done before we release 1.19.0.
Related branches
lp:~dimitern/juju-core/394-network-name-to-id-and-add-tags
- Dimiter Naydenov (community): Approve
-
Diff: 1769 lines (+653/-226)33 files modifiedcmd/juju/deploy.go (+2/-2)
environs/broker.go (+19/-4)
errors/errors.go (+4/-5)
errors/errors_test.go (+9/-0)
names/network.go (+24/-0)
names/network_test.go (+52/-0)
names/tag.go (+3/-0)
names/tag_test.go (+13/-1)
provider/dummy/environs.go (+6/-1)
provider/maas/environ.go (+3/-2)
state/addmachine.go (+4/-4)
state/address.go (+9/-2)
state/api/client.go (+3/-2)
state/api/params/internal.go (+25/-9)
state/api/provisioner/machine.go (+2/-2)
state/api/provisioner/provisioner_test.go (+29/-20)
state/apiserver/client/client.go (+25/-3)
state/apiserver/client/client_test.go (+10/-1)
state/apiserver/provisioner/provisioner.go (+51/-7)
state/apiserver/provisioner/provisioner_test.go (+30/-22)
state/apiserver/uniter/uniter_test.go (+3/-3)
state/apiserver/usermanager/usermanager_test.go (+2/-2)
state/machine.go (+29/-19)
state/machine_test.go (+85/-52)
state/networkinterfaces.go (+35/-3)
state/networkinterfaces_test.go (+3/-1)
state/networks.go (+32/-5)
state/networks_test.go (+4/-2)
state/open.go (+13/-10)
state/state.go (+41/-16)
state/state_test.go (+69/-18)
worker/provisioner/provisioner_task.go (+8/-6)
worker/provisioner/provisioner_test.go (+6/-2)
| Changed in juju-core: | |
| milestone: | none → 1.19.0 |
| Changed in juju-core: | |
| status: | In Progress → Fix Committed |
| Changed in juju-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
