Validate backup size with flavor and volume size on restore operation

Bug #1304603 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Denis M.

Bug Description

Trove doesn't do the validation of the backup size with flavor(for non-volume instances) and volume size(for cinder volumes).
This could cause the exception at guest side - not enough space.

API service should rize the exceptions when mentioned backup is too big for proposed volume/flavor

Denis M. (dmakogon)
Changed in trove:
assignee: nobody → Denis M. (dmakogon)
status: New → In Progress
summary: - validate backup size with flavor and volume size on restore operation
+ Validate backup size with flavor and volume size on restore operation
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86300

Changed in trove:
importance: Undecided → Low
Denis M. (dmakogon)
Changed in trove:
milestone: none → juno-3
Changed in trove:
milestone: juno-3 → juno-rc1
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

This issue is not release critical to hold juno-rc1 for. Moving to kilo-1.

Changed in trove:
milestone: juno-rc1 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/86300
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=1611ba0b4f52469b4bdd2de2e55d8cc1af9d7621
Submitter: Jenkins
Branch: master

commit 1611ba0b4f52469b4bdd2de2e55d8cc1af9d7621
Author: Denis Makogon <email address hidden>
Date: Wed Sep 3 14:55:00 2014 +0300

    Validate backup size during restore

    Reasons:
     - A user is able to pass a backup that is larger
       than the volume/disk of the instance can handle.

    Changes:
     - Add validation to backup size according to volume
       or flavor size of the disk;
     - Add tests.

    Change-Id: Id549cff2e572a0ada632759bd9fcbbb67edf6ae0
    Closes-Bug: #1304603

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.