bash-completion subcommand

Bug #1304488 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
Low
Ruby Loo

Bug Description

The documentation folks use 'commands.py' (https://github.com/openstack/openstack-doc-tools/blob/master/os_doc_tools/commands.py) that is used to generate documentation for commands and subcommands (eg http://docs.openstack.org/user-guide/content/keystoneclient_commands.html). It uses the 'bash-completion' subcommand (if there is one) to get the subcommands. Since there is no 'ironic bash-completion', the subcommands are currently hard-coded. Which means that when we add/change the subcommands, this list will need to be updated. A bash-completion subcommand would be preferable.

Dmitry Tantsur (divius)
Changed in python-ironicclient:
status: New → Confirmed
Revision history for this message
Dmitry Tantsur (divius) wrote :

Work already started as part of more generic bug

Revision history for this message
Ruby Loo (rloo) wrote :

Most of the work was done in https://bugs.launchpad.net/python-ironicclient/+bug/1332408. It looks like the only thing missing is to add 'bash-completion' to the list of subcommands when you do 'ironic' or 'ironic help'.

Changed in python-ironicclient:
assignee: nobody → Ruby Loo (rloo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120122

Changed in python-ironicclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/120122
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=70b27a083c72fad73ef388e3549953aaf9940af5
Submitter: Jenkins
Branch: master

commit 70b27a083c72fad73ef388e3549953aaf9940af5
Author: Ruby Loo <email address hidden>
Date: Tue Sep 9 15:11:18 2014 +0000

    Add 'bash-completion' to 'ironic help' response

    If you do 'ironic' or 'ironic help', it will show a list of subcommands.
    This adds 'bash-completion' to that list.

    The 'ironic bash-completion' subcommand lists all of the commands.
    It won't include 'bash-completion' in this list, to be consistent with
    nova's and keystone's bash-completion subcommand.

    Change-Id: I7f2b76ad2885d9fe34dc91a97ee77984a21a27f4
    Closes-Bug: #1304488

Changed in python-ironicclient:
status: In Progress → Fix Committed
Changed in python-ironicclient:
milestone: none → 0.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.