Submitting an empty search form crashes Arnold

[Morten Brekkevold]

In NAV 3.15 and 4.0, when submitting an empty search form in arnold (/arnold/search), the page crashes with a TypeError.

Traceback looks like this under NAV 3.15:

Traceback (most recent call last):

  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib/pymodules/python2.7/nav/web/arnold/views.py", line 96, in render_search
    if form.is_valid():

  File "/usr/lib/python2.7/dist-packages/django/forms/forms.py", line 124, in is_valid
    return self.is_bound and not bool(self.errors)

  File "/usr/lib/python2.7/dist-packages/django/forms/forms.py", line 115, in _get_errors
    self.full_clean()

  File "/usr/lib/python2.7/dist-packages/django/forms/forms.py", line 271, in full_clean
    self._clean_form()

  File "/usr/lib/python2.7/dist-packages/django/forms/forms.py", line 299, in _clean_form
    self.cleaned_data = self.clean()

  File "/usr/lib/pymodules/python2.7/nav/web/arnold/forms.py", line 72, in clean
    IP(searchvalue)

  File "/usr/lib/python2.7/dist-packages/IPy.py", line 250, in __init__
    raise TypeError("Unsupported data type: %s" % type(data))

TypeError: Unsupported data type: <type 'NoneType'>

[John-Magne Bredal (john-m-bredal)]

Fix for 4.0: https://nav.uninett.no/hg/stable/rev/e44f34773b01

Fix for 3.15: https://nav.uninett.no/hg/stable/rev/4ddedb13d9ce