update alarm combination can specify alarm_id of itself as the value of "--alarm_ids"

Bug #1304419 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
ZhiQiang Fan
Havana
Fix Released
Undecided
Unassigned
Icehouse
Fix Released
Low
ZhiQiang Fan

Bug Description

update alarm combination can specify "alarm_id of itself as the value of "--alarm_ids", this will cause an endless loop when evaluating this alarm.

Liusheng (liusheng)
Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86181

Changed in ceilometer:
assignee: Liusheng (liusheng) → ZhiQiang Fan (aji-zqfan)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/86515

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/86181
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=de8176fa736ffa9c4d6b0a57a8db2f58083f124a
Submitter: Jenkins
Branch: master

commit de8176fa736ffa9c4d6b0a57a8db2f58083f124a
Author: ZhiQiang Fan <email address hidden>
Date: Wed Apr 9 06:27:28 2014 +0800

    Disable specifying alarm itself in combination rule

    Currently, update combination alarm can specify itself in alarm_ids,
    however, that will cause endless loop when evaluating this alarm.

    This patch adds a check to disable such behavior.

    Change-Id: I63b465c59fe39206ae04b0736482d1ffd7bf59c4
    Closes-Bug: #1304419

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ceilometer (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/92048

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → juno-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/icehouse)

Reviewed: https://review.openstack.org/92048
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=82eed262144546d145bed465a23edd189578e815
Submitter: Jenkins
Branch: stable/icehouse

commit 82eed262144546d145bed465a23edd189578e815
Author: ZhiQiang Fan <email address hidden>
Date: Wed Apr 9 06:27:28 2014 +0800

    Disable specifying alarm itself in combination rule

    Currently, update combination alarm can specify itself in alarm_ids,
    however, that will cause endless loop when evaluating this alarm.

    This patch adds a check to disable such behavior.

    Change-Id: I63b465c59fe39206ae04b0736482d1ffd7bf59c4
    Closes-Bug: #1304419
    (cherry picked from commit de8176fa736ffa9c4d6b0a57a8db2f58083f124a)

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/havana)

Reviewed: https://review.openstack.org/86515
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=98acce568f45cb94c2a5bb2f1066598e8be285f1
Submitter: Jenkins
Branch: stable/havana

commit 98acce568f45cb94c2a5bb2f1066598e8be285f1
Author: ZhiQiang Fan <email address hidden>
Date: Wed Apr 9 06:27:28 2014 +0800

    Disable specifying alarm itself in combination rule

    Currently, update combination alarm can specify itself in alarm_ids,
    however, that will cause endless loop when evaluating this alarm.

    This patch adds a check to disable such behavior.

    Change-Id: I63b465c59fe39206ae04b0736482d1ffd7bf59c4
    Closes-Bug: #1304419
    (cherry picked from commit de8176fa736ffa9c4d6b0a57a8db2f58083f124a)

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.