NULL ptr dereference in LAN91xDxe

Bug #1304402 reported by Mark Salter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro UEFI
New
Undecided
Roy Franz

Bug Description

I tried adding LAN91xDxe support to Foundation model and ran
into a NULL ptr dereference of DstAddr in SnpTransmit():

  // Check for the nature of the frame
  if (DstAddr->Addr[0] == 0xFF) {
    LanDriver->Stats.TxBroadcastFrames += 1;
  } else if ((DstAddr->Addr[0] & 0x1) == 1) {
    LanDriver->Stats.TxMulticastFrames += 1;
  } else {
    LanDriver->Stats.TxUnicastFrames += 1;
  }

DstAddr is passed into SnpTransmit and is an optional argument.
Not sure why this wasn't seen on FVP model. Patch attached, but
it may not be the proper fix.

Revision history for this message
Mark Salter (msalter) wrote :
Revision history for this message
Leif Lindholm (leif-lindholm) wrote :

Steve, have a look at how this pans out once ARM's Ethernet drivers go upstream. Should be in time for 2014.05.

Changed in linaro-uefi:
assignee: nobody → Steven Kinney (steven-kinney)
Ilias Biris (ibiris)
Changed in linaro-uefi:
assignee: Steven Kinney (steven-kinney) → Roy Franz (roy-franz)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.