Horizon requires pbr at runtime

[Matthias Runge]

The only occurance of pbr is:
grep -r 'pbr' *

version.py:import pbr.version
version.py:version_info = pbr.version.VersionInfo('horizon')

That can be replaced by something like this:
class VersionInfo(object):
    release = "2014.1"
    version = "1"

    def version_string(self):
        return self.version

    def release_string(self):
        return self.release

version_info = VersionInfo()

[Julie Pichon (jpichon)]

This seems to be the way all OpenStack projects use pbr and do versioning. If this needs to be changed I'm not sure that should happen only in Horizon, pbr does other handy things that a hard-coded version would not cover.

[Matthias Runge (mrunge)]

Yes, I'm aware of that. Still, pbr is used to create static texts at each call. It will be sufficient to do this once for a release. And I'm sure, pbr can do that, too (at build time).

[Julie Pichon (jpichon)]

It also infers version number based on git commits for intermediate versions, and I wouldn't be surprised if it was required for parts of the release process. I think Horizon should keep consistent with the other OpenStack projects. Perhaps bring it up on list to see if the pbr dependency could be handled differently, consistently across the projects?

[Pádraig Brady (p-draigbrady)]

This might be a change done at least initially downstream.

Does it work to set this in the rpm before the setup.py build?
  export OSLO_PACKAGE_VERSION=%{version}

An alternative approach is to do as you suggest in the description,
but more parameterized like:
  http://pkgs.fedoraproject.org/cgit/openstack-neutron.git/tree/0001-remove-runtime-dependency-on-pbr.patch
Then in the rpm build one can do:
  sed -i 's/RPMVERSION/%{version}/; s/RPMRELEASE/%{release}/' horizon/version.py

[Julie Pichon (jpichon)]

Removing the low-hanging-fruit tag, since this will first require an on-list discussion to make sure the resolution is agreed on by and kept consistent across the projects.

[Matthias Runge (mrunge)]

for reference: swiftclient removed that dep last October:
https://github.com/openstack/python-swiftclient/commit/7d61c543993638caf5dbe176ed6c077ee506d87e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/92814

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthias Runge (<email address hidden>) on branch: master
Review: https://review.openstack.org/92814
Reason: lack of interest upstream horizon

[David Lyle (david-lyle)]

I think this is a larger OpenStack issue and not for Horizon to solve independently. You can't really do much Horizon without OpenStack, the same is not true of swift.