link prefixes are truncated

Bug #1304099 reported by Evan Petrie
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Deliang Fan
OpenStack Compute (nova)
Fix Released
Low
Christopher Yeoh

Bug Description

The osapi_glance_link_prefix and osapi_compute_link_prefix configuration parameters have their paths removed. For instance, if nova.conf contains

osapi_compute_link_prefix = http:/127.0.0.1/compute/

the values displayed in the API response exclude the "compute/" component. Other services, such as keystone, retain the path.

This bit of code is where the bug occurs:

https://github.com/openstack/nova/blob/673ecaea3935b6a50294f24f8a964590ca07a959/nova/api/openstack/common.py#L568-L582

Tags: api
description: updated
description: updated
Tracy Jones (tjones-i)
tags: added: api
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Christopher Yeoh (cyeoh-0)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/107916

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/107916
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bbb0f22fa91f678049e22c9d203d74010421043a
Submitter: Jenkins
Branch: master

commit bbb0f22fa91f678049e22c9d203d74010421043a
Author: Chris Yeoh <email address hidden>
Date: Fri Jul 18 16:54:45 2014 +0930

    Don't truncate osapi_glance_link or osapi_compute_link prefixes

    When osapi_glance_link_prefix or osapi_compute_link_prefix is
    defined and used to update the links return in API responses, do
    not drop the path component of the overriding link prefix.

    Change-Id: I290e3f85b94e28d25a54621c1699081cbbf48456
    Closes-Bug: 1304099

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
Changed in cinder:
assignee: nobody → Deliang Fan (vanderliang)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177069

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/177069
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=4edfd79265d89a438554acd5266933f8e20c9ff0
Submitter: Jenkins
Branch: master

commit 4edfd79265d89a438554acd5266933f8e20c9ff0
Author: Deliang Fan <email address hidden>
Date: Fri Apr 24 11:16:46 2015 +0800

    Don't truncate osapi_volume_link prefixes

    When osapi_volume_link_prefix is defined and used to update the
    links return in API responses, do not drop the path component of
    the overriding link prefix.

    Change-Id: Ic84e16cdfa989d4af7f076a4c244808be2ca4dce
    Closes-Bug: #1304099

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.