force_config_drive=True don't go to db

[Nikolay Starodubtsev]

If we use --config-drive=True via client we'll have filled config_drive column in db. In the other hand if we use force_config_drive=True in nova.conf the column will be empty. Also, in both cases config drive will be attached to vm, and I can't find any problems with live-migration or evacuation. In my deployment I use shared storage.

[Thang Pham (thang-pham)]

Are you saying --config-drive=True via client and force_config_drive=True via nova.conf should both set the config_drive db column? I believe it maybe intended to work that way because if force_config_drive=False in nova.conf, setting --config-drive=True via client is a way to override the nova.conf setting.

[Nikolay Starodubtsev (starodubcevna)]

I think that if we have force_config_drive = True in nova.conf the column in db should be filled with True. Isn't it obvious?

[Thang Pham (thang-pham)]

I see the db column more as a way to override the default behavior found in nova.conf, but I see your point.

[Thang Pham (thang-pham)]

This is related to bug #1193438. One comment from Michael Still on bug #1193438 is:
    I've reviewed the code review for this one, and I think changing this is a bad idea.

[Michael Still (mikal)]

That's not really true -- what I was saying in that review is that I think changing the type of the DB column is a bad idea. I think having the right data in that column (this bug) is a good idea though.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/92899

[Sean Dague (sdague)]

Patch dead

[Michael Still (mikal)]

Actually not dead. I was rebasing it yesterday.

(Although I admit its sat around for a long time).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/92899
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[stgleb (gstepanov)]

Stepghe, are you still working on this patch?

[Stephen Finucane (stephenfinucane)]

@stgleb: Yes, I have a patch waiting for review.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/92899

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/364814

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/376452
Reason: not actual

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/364814
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.