test_rollback_on_router_delete fails

[Irena Berezovsky]

gate-neutron-python26 failis for test_rollback_on_router_delete with following error:
2014-04-07 03:53:51,643 ERROR [neutron.plugins.bigswitch.servermanager] ServerProxy: POST failure for servers: ('localhost', 9000) Response: {'status': 'This server is broken, please try another'}
2014-04-07 03:53:51,643 ERROR [neutron.plugins.bigswitch.servermanager] ServerProxy: Error details: status=500, reason='Internal Server Error', ret={'status': 'This server is broken, please try another'}, data="{'status': 'This server is broken, please try another'}"
}}}

Traceback (most recent call last):
  File "neutron/tests/unit/bigswitch/test_router_db.py", line 536, in test_rollback_on_router_delete
    expected_code=exc.HTTPInternalServerError.code)
  File "neutron/tests/unit/test_db_plugin.py", line 450, in _delete
    self.assertEqual(res.status_int, expected_code)
  File "/home/jenkins/workspace/gate-neutron-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 321, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/jenkins/workspace/gate-neutron-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: 204 != 500

full log is here:
http://logs.openstack.org/29/82729/3/check/gate-neutron-python26/a1065eb/testr_results.html.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/85917

[Kevin Benton (kevinbenton)]

this can be reproduced by running testr in master with a test list containing these two tests.

neutron.tests.unit.bigswitch.test_capabilities.CapabilitiesTests.test_keep_alive_capability
neutron.tests.unit.bigswitch.test_router_db.RouterDBTestCase.test_rollback_on_router_delete

e.g.
source .tox/py27/bin/activate
testr run -- --load-list=file_with_two_tests

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85917
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b12e38327af83f44cc8e38a23d16bb51a2346f57
Submitter: Jenkins
Branch: master

commit b12e38327af83f44cc8e38a23d16bb51a2346f57
Author: Kevin Benton <email address hidden>
Date: Mon Apr 7 20:25:23 2014 -0700

    BigSwitch: Stop HTTP patch before overriding

    Stops the default HTTPConnection patch used by the
    Big Switch tests before patching HTTPConnection with
    another substitution. This prevents mock from losing
    track of the default patch which was resulting in it
    not consistently being stopped by the stopall call in
    cleanup.

    This also corrects an incorrectly targeted mock for the
    HTTP patch in one of the test files.

    Closes-Bug: #1303605
    Change-Id: Ia5b374c5f8d3a7905d915de4f1f8d4f3a6f0e58d