No testcases for zeromq

Bug #1302941 reported by Li Ma
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Low
James Page

Bug Description

It seems that there are no testcases for zeromq.

Tags: zmq
Li Ma (nick-ma-z)
description: updated
Mark McLoughlin (markmc)
Changed in oslo.messaging:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Li Ma (nick-ma-z) wrote :

I just find that test cases for zeromq and matchmaker drivers have already been developed in oslo-incubator.
Is it possible to move them to oslo.messaging or still need to rework the whole stuff?

Changed in oslo.messaging:
assignee: nobody → Michael H Wilson (geekinutah)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/93905

Changed in oslo.messaging:
status: Triaged → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :

There's a bunch of zeromq jobs in jenkins with no build history:

  https://jenkins.openstack.org/search/?q=zeromq

(it sounds like this bug is about unit/functional tests, but figured it'd be worth pointing out anyway.)

Mark McLoughlin (markmc)
tags: added: zmq
Revision history for this message
James Page (james-page) wrote :

I've started work on breaking down the tests we put together at a sprint last month into digestable chunks; first up will be matchmaker tests, followed by driver tests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/128205

Changed in oslo.messaging:
assignee: Michael H Wilson (geekinutah) → James Page (james-page)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/128233

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/128205
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=5aadc56b66c2d8504e9177b553359d2c01b367f4
Submitter: Jenkins
Branch: master

commit 5aadc56b66c2d8504e9177b553359d2c01b367f4
Author: James Page <email address hidden>
Date: Tue Oct 14 09:34:59 2014 +0100

    Add basic tests for 0mq matchmakers

    Basic unit tests for in-memory (localhost), ring and Redis based
    matchmakers.

    Redis tests are opportunitic based on a redis-server being installed
    and running.

    Test are currently skipped under py3 due to direct dependency on
    eventlet.

    Co-Authored-By: Kapil Thangavelu <email address hidden>
    Change-Id: I59c4d095033370ab94f645af0d50e2502530f816
    Partial-bug: #1302941

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/128233
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=cd71c47d326e8d5d2aa2d586e0f9874a45da4d6c
Submitter: Jenkins
Branch: master

commit cd71c47d326e8d5d2aa2d586e0f9874a45da4d6c
Author: James Page <email address hidden>
Date: Tue Oct 14 11:08:54 2014 +0100

    Add functional and unit 0mq driver tests

    Basic functional and unit tests for zmq driver.

    Note as the zmq driver is directly dependent on eventlet, this
    change also updates the notify logger tests to remove the
    direct dependency on threading which was being monkey patched,
    causing test failures.

    As the zmq driver has a direct dependency on eventlet, tests are
    skipped under py3.

    Co-Authored-By: Kapil Thangavelu <email address hidden>
    Co-Authored-By: Edward Hope-Morley <email address hidden>

    Change-Id: I93b8b2e92d0f2a353d3357a5e61f6d472ec84944
    Partial-bug: #1302941

Revision history for this message
James Page (james-page) wrote :

OK - I think we can mark this as fix committed now!

Changed in oslo.messaging:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (master)

Change abandoned by Michael H Wilson (<email address hidden>) on branch: master
Review: https://review.openstack.org/93905
Reason: I appreciate the reviews, I have not had time to work on this at all and won't for the foreseeable future. Abandoning this change for now :-(.

Changed in oslo.messaging:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.