Sheepdog store accept GET and DELETE request still even failed to configure essential option

[Zhi Yan Liu]

Currently if store raise BadStoreConfiguration exception from configure_add method, the glance will just make this store be readonly instead of fully disable, but for the logic of sheepdog configure_add, it contains all essential initial configurations for the store which are necessary for the store be fully functional, so if any one of they get failed the store should be full block up instead of being readonly accessible.

The related test cases need to be handled as well.

[Zhi Yan Liu (lzy-dev)]

We'd better do the fix after https://bugs.launchpad.net/glance/+bug/1298698 landing.

[Zhi Yan Liu (lzy-dev)]

https://review.openstack.org/#/c/100181/1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100181
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0d4524e53cbed8d218c566a4e9c5313137fb537d
Submitter: Jenkins
Branch: master

commit 0d4524e53cbed8d218c566a4e9c5313137fb537d
Author: Zhi Yan Liu <email address hidden>
Date: Mon Jun 16 16:04:04 2014 +0800

    Changing Sheepdog driver to use correct configuration function

    Currently Sheepdog store driver is using configure_add() to handle
    those essential options, which are not only be used for image 'add'
    handling but also for other key functions e.g. 'get_size', 'get' and
    etc. When store driver raises BadStoreConfiguration exception from
    configure_add(), Glance will just makes this store be readonly instead
    of fully disabled, so the handling for all the essential configurations
    should be implemented in configure(), and then if any option of them get
    failure the store will be fully disabled instead of being readonly
    partially.

    Closes-bug: 1302658

    Change-Id: Idaa96036515f04ee8414f30990ee638855ede2d2
    Signed-off-by: Zhi Yan Liu <email address hidden>