RbdTestCase.test_cache_base_dir_exists is duplicated in test_imagebackend

Bug #1302211 reported by Dmitry Borodaenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Dmitry Borodaenko

Bug Description

RbdTestCase in nova/tests/virt/libvirt/test_imagebackend.py now has two slightly different versions of the same test case:
https://github.com/openstack/nova/blob/dc8de426066969a3f0624fdc2a7b29371a2d55bf/nova/tests/virt/libvirt/test_imagebackend.py#L759
https://github.com/openstack/nova/blob/dc8de426066969a3f0624fdc2a7b29371a2d55bf/nova/tests/virt/libvirt/test_imagebackend.py#L806

The redundant version was added in:
https://review.openstack.org/82840

I think it should be removed, it doesn't do anything the original test case doesn't already have.

Tags: testing
Revision history for this message
Matt Riedemann (mriedem) wrote :
tags: added: testing
Changed in nova:
status: New → In Progress
assignee: nobody → Dmitry Borodaenko (dborodaenko)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/85187
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2634616e3d94b57600090f3262c96e2233a521f8
Submitter: Jenkins
Branch: master

commit 2634616e3d94b57600090f3262c96e2233a521f8
Author: Dmitry Borodaenko <email address hidden>
Date: Thu Apr 3 14:54:03 2014 -0700

    remove redundant copy of test_cache_base_dir_exists

    Second copy of RbdTestCase.test_cache_base_dir_exists was accidentally
    introduced in https://review.openstack.org/82840.

    Change-Id: I16b2e472b2499f01379fdca9c860da0b95e291d8
    Closes-bug: #1302211
    Signed-off-by: Dmitry Borodaenko <email address hidden>

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/85744

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/85744
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=576d5a90a7521d56080e14a91d162164c45e3aa4
Submitter: Jenkins
Branch: master

commit 576d5a90a7521d56080e14a91d162164c45e3aa4
Author: Matt Riedemann <email address hidden>
Date: Mon Apr 7 08:44:07 2014 -0700

    Remove redundant tests from Qcow2TestCase

    Qcow2TestCase had exact copies of two tests in the parent
    _ImageTestCase so remove them. I'm assuming the tests originated
    in Qcow2TestCase but later more image types were added and the
    tests were pulled up into the common parent mixin since they
    applied to all types of images, but the redundant tests from
    Qcow2TestCase weren't cleaned up.

    Related-Bug: #1302211

    Change-Id: I031516b555ead5a3769fb62d90e373aac1b6baf1

Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.