Redundant SG rule create calls in unit tests

[Sridhar Gaddam]

The following test cases in TestSecurityGroups of test_extension_security_group.py file
are making multiple calls to create a SG rule.
test_create_security_group_rule_min_port_greater_max()
test_create_security_group_rule_ports_but_no_protocol()
test_create_security_group_rule_port_range_min_only()
test_create_security_group_rule_port_range_max_only()
test_create_security_group_rule_icmp_type_too_big()
test_create_security_group_rule_icmp_code_too_big()

The redundant calls can be removed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/85127

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85127
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c49ec8b3ba10bb414a0f135d29ff3685e26d58b3
Submitter: Jenkins
Branch: master

commit c49ec8b3ba10bb414a0f135d29ff3685e26d58b3
Author: sridhargaddam <email address hidden>
Date: Thu Apr 3 23:29:37 2014 +0530

    Redundant SG rule create calls in unit tests

    This patch removes the redundant calls in the test cases.

    Closes-Bug: #1302091
    Change-Id: I509843b427dc454c0e6b2fd2cbff1bbbb284337f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85507

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85507
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=354bc1ab4b1490b72abf80cfd2860337f1ccb369
Submitter: Jenkins
Branch: milestone-proposed

commit 354bc1ab4b1490b72abf80cfd2860337f1ccb369
Author: sridhargaddam <email address hidden>
Date: Thu Apr 3 23:29:37 2014 +0530

    Redundant SG rule create calls in unit tests

    This patch removes the redundant calls in the test cases.

    Closes-Bug: #1302091
    Change-Id: I509843b427dc454c0e6b2fd2cbff1bbbb284337f
    (cherry picked from commit c49ec8b3ba10bb414a0f135d29ff3685e26d58b3)