neutron

ODL ML2 driver doesn't warn if the url parameter is not set

Bug #1301432 reported by Simon Pasquier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton
neutron 2014.2 "juno"
Icehouse
New
Undecided
Unassigned

Bug Description

If you don't define the "url" parameter in the [ml2_odl] section of the ML2 configuration file, the ODL driver will run happily but no request will be made to the ODL service. See http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ml2/drivers/mechanism_odl.py?id=a57dc2c30ab78ba74cfc51b8fdb457d3374cc87d#n313

The parameter should have a sane default value (eg http://127.0.0.1:8080/controller/nb/v2/neutron) and/or a message should be logged to warn the deployer.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/85589

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/85589
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2da351af7d2a10a3055020d572d357c56ba2689b
Submitter: Jenkins
Branch: master

commit 2da351af7d2a10a3055020d572d357c56ba2689b
Author: Kevin Benton <email address hidden>
Date: Sun Apr 6 04:29:07 2014 -0700

    Enforce required config params for ODL driver

    Raise a config error during initialization if
    there is no URL, username, or password specified
    in the config for the OpenDayLight ML2 driver.

    Closes-Bug: #1301432
    Change-Id: I65fc94d3eaaade3d1402d1c82d2c1edfa7133d5a

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Cédric OLLIVIER (m.col)
tags: added: icehouse-backport-potential opendaylight
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/122932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/122932
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=45b01c1c8543d8586633de4d01353f7f3c553a4d
Submitter: Jenkins
Branch: stable/icehouse

commit 45b01c1c8543d8586633de4d01353f7f3c553a4d
Author: Kevin Benton <email address hidden>
Date: Sun Apr 6 04:29:07 2014 -0700

    Enforce required config params for ODL driver

    Raise a config error during initialization if
    there is no URL, username, or password specified
    in the config for the OpenDayLight ML2 driver.

    Also ensure core plugin deallocation after every
    test [1] following the previous backport [2].

    [1] https://review.openstack.org/#/c/92793/
    [2] https://review.openstack.org/#/c/102329/

    Closes-Bug: #1301432
    Change-Id: I65fc94d3eaaade3d1402d1c82d2c1edfa7133d5a
    (cherry picked from commit 2da351af7d2a10a3055020d572d357c56ba2689b)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.