neutron

We have three duplicated tests for check_ovs_vxlan_version

Bug #1301337 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki
neutron 2014.2 "juno"

Bug Description

test_ovs_lib, test_ovs_neutron_agent and test_ofa_neutron_agent have duplicated same unit tests for check_ovs_vxlan_version. The only difference is SystemError (from ovs_lib) and SystemExit (from agents).
The tested logic is 99% same, and unit tests in ovs/ofa agent looks unnecessary.

Tags: unittest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84703

Changed in neutron:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/84703
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=58f33fd3ef7b66bb570ef757b9f70a023e0c8c59
Submitter: Jenkins
Branch: master

commit 58f33fd3ef7b66bb570ef757b9f70a023e0c8c59
Author: Akihiro Motoki <email address hidden>
Date: Wed Apr 2 21:02:35 2014 +0900

    Remove duplicated tests for check_ovs_vxlan_version

    test_ovs_lib, test_ovs_neutron_agent and test_ofa_neutron_agent
    have duplicated same unit tests for check_ovs_vxlan_version.
    This commits removes tests from ovs/ofa_neutron_agent.

    Change-Id: Ia028a4afc1c8154f895187c979d23b626ab4ae3a
    Closes-Bug: #1301337

Changed in neutron:
status: In Progress → Fix Committed
ram (ravipaty)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.