Abandon stack lacks locking

Bug #1301311 reported by Steven Hardy
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Vijendar Komalla

Bug Description

delete_stack in service.py contains locking logic, so we can avoid races where other actions are performed on a stack while it's being deleted.

abandon_stack does essentially the same thing, but lacks any locking, so there will be problems if one engine does an abandon while another is servicing some other lifecycle request, like a stack update for example.

Changed in heat:
assignee: nobody → Vijendar Komalla (vijendar-komalla)
Changed in heat:
status: New → In Progress
Changed in heat:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86663

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/86663
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f9c0ae9ca3b7187ee831d14b5143356deeb6785f
Submitter: Jenkins
Branch: master

commit f9c0ae9ca3b7187ee831d14b5143356deeb6785f
Author: Vijendar Komalla <email address hidden>
Date: Thu Apr 10 12:46:04 2014 -0500

    Implement locking in abandon stack

    This change implements locking in abandon stack. If lock
    acquire fails throws ActionInPrgoress exception.

    Change-Id: I930123efa95b2863c4e2de01f4646b6e3d68c5cc
    Closes-bug: #1301311

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.