LDAP users with non-ASCII characters in their name cause login page to crash when user lookup method is 'search' (MS AD)

[Morten Brekkevold]

Traceback from Ålesund University College:

[Tue Apr 01 11:29:17 2014] [ERROR] [pid=18668 django.request] Internal Server Error: /index/login/
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/dist-packages/django/views/decorators/debug.py", line 69, in sensitive_post_parameters_wrapper
    return view(request, *args, **kwargs)
  File "/usr/lib/pymodules/python2.7/nav/web/webfront/views.py", line 92, in login
    return do_login(request)
  File "/usr/lib/python2.7/dist-packages/django/views/decorators/debug.py", line 34, in sensitive_variables_wrapper
    return func(*args, **kwargs)
  File "/usr/lib/pymodules/python2.7/nav/web/webfront/views.py", line 127, in do_login
    account = auth.authenticate(username, password)
  File "/usr/lib/pymodules/python2.7/nav/web/auth.py", line 95, in authenticate
    auth = ldapauth.authenticate(username, password)
  File "/usr/lib/pymodules/python2.7/nav/web/ldapauth.py", line 127, in authenticate
    user.bind(password)
  File "/usr/lib/pymodules/python2.7/nav/web/ldapauth.py", line 186, in bind
    self.ldap.simple_bind_s(user_dn.encode(encoding),
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 18: ordinal not in range(128)

Analysis:

The code does not consider that the user search result from the
LDAP server is already encoded as UTF-8. Attempting to encode an already
encoded string will cause Python to attempt to decode it from ASCII to
unicode, before encoding that as UTF-8 again.

[Morten Brekkevold (mbrekkevold)]

fix here: https://nav.uninett.no/hg/stable/rev/23d774154094