floating ip quota error neutron

[Robert Collins]

Found with nodepool on the tripleo CI cloud - when the neutron floating IP quota is exhausted, novaclient add-floating-ip threw a generic 500.

ClientException: The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID:
               req-43db38fd-5b65-40be-960f-d00bf74e23b9)

 /var/log/upstart/nova-api.log:2014-04-02 02:30:03.375 7736 ERROR nova.api.openstack [req-43db38fd-5b65-40be-960f-d00bf74e23b9
                  d5af62d2183d431796d74c5bb119ec9f e01e473a9250498883955b80966a1e58] Caught error: 409-{u'NeutronError': {u'message': u"Quota exceeded for
                  resources: ['floatingip']", u'type': u'OverQuota', u'detail': u''}}

was found in our logs - so this should be caught and rethrown appropriately.

[Robert Collins (lifeless)]

Ib5320a13b5cc0c493ef0763d0e2b4575dc699bdf was meant to address this, or something similar, but doesn't seem to have.

[jichenjc (jichenjc)]

is this similar to https://review.openstack.org/#/c/62581/?
I can mark this bug closed if that patch is merged

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62581
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9f06c76645a56d66cce5f33a5fd5a3b96a7eb421
Submitter: Jenkins
Branch: master

commit 9f06c76645a56d66cce5f33a5fd5a3b96a7eb421
Author: Huang Rui <email address hidden>
Date: Mon Dec 16 22:14:55 2013 -0500

    Handle over quota exception from Neutron

    When using the floating IP in Nova with Neutron, and
    a quota limit is exceeded in Neutron, the exception from
    the Neutron client results in Nova generating a 500 error.
    This is unhelpful to user, and not consistent with nova-networking
    Return FloatingIPExceedLimit exception when quota exceeded.

    Change I8788993578ac872da9f676fe3e2fb8f98414289d at neutronclient
    add OverQuotaClient exception and it is used in this patch

    Change-Id: Ieb90521cf231acae8b5a9920acf6c77f2e34ef67
    Closes-Bug: #1210598
    Closes-Bug: #1301117