missing single quots in ssh plugin /src/plugins/ssh/ssh.c

[meamy]

I'm not 100% shure if this is a bug or if there is a reason for this.

/src/plugins/ssh/ssh.c line 424

sshinfo->server, "echo " SENTINEL "; exec /bin/sh -", NULL);

this will start /bin/sh on the Client, I guess this is supossed to start on the Server and there for there need to be single quotes around the whole String.
I stumbled over this because without /bin/sh started on the Server the unlocking of the
gnome-login-keyring over /etc/pam.d/sshd is not working (the gnome-keyring-daemon is not started
at all) with an intital running /bin/sh this is functioning.

root@tc51:~# apt-cache policy ldm
ldm:
  Installiert: 2:2.2.9-1ubuntu0.1
  Kandidat: 2:2.2.9-1ubuntu0.1
  Versionstabelle:
 *** 2:2.2.9-1ubuntu0.1 0
        500 http://10.12.12.12/ubuntu/ precise-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     2:2.2.9-1 0
        500 http://10.12.12.12/ubuntu/ precise/main amd64 Packages
root@tc51:~# uname -a
Linux tc51 3.2.0-38-generic #61-Ubuntu SMP Tue Feb 19 12:18:21 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "ssh_plugin.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Alkis Georgopoulos (alkisg)]

AFAIK, you can see the `exec /bin/sh -` running on the server if you run `ps` there.
The "gnome-keyring is not unlocked" part is due to LDM not using PAM to unlock the keyring, like lightdm does.

So I'm marking this as Invalid, please reopen it if my rationale was wrong.