event list not showing proper message for deployment signal

[Qiming Teng]

The event list for a stack that contains SoftwareDeployment resource with signal_transport set to values other than 'NO_SIGNAL', we will (hopefully) get a signal from a VM server.

When the signal is processed at the engine/resource level, it cannot process the 'details' sent with the signal that contains {deploy_stdout: xxx, deploy_stderr: yyy, deploy_status_code: <n> }. So when a user tries 'heat event-list', the resource_status_reason for the event is simply 'Unknown'.

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/84665
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5df976875f8dbdd0ada5a66e534547e764a30231
Submitter: Jenkins
Branch: master

commit 5df976875f8dbdd0ada5a66e534547e764a30231
Author: tengqm <email address hidden>
Date: Thu Apr 3 04:44:40 2014 +0800

    Fix status reason in events for deployment signals

    When a signal is received and processed by a Resource, there could be an
    event generated automatically. For such an event, Heat is supposed to
    provide some useful message (including status_reason). But currently,
    the resource code can only process ceilometer alarms and watch rules,
    for signals sent for a SoftwareDeployment resource, the signal is only
    providing an string 'Unknown' as the status change reason. This is
    confusing when a user performs 'heat event-list stack'.

    This patch adds an additional check (guess) whether the signal comes
    from a SoftwareDeployment. If that is the case, fill in the status
    reason as 'deployment succeeded', or 'deployment failed (n)', where n is
    the deploy_status_code that comes with the signal.

    Closes-Bug: #1300679
    Change-Id: Ic970a5dac923fffdcdd365983df58f4d338de849

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/95923

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95923
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=930cb3c3e72829c959e128d4a6e4002265697a59
Submitter: Jenkins
Branch: stable/icehouse

commit 930cb3c3e72829c959e128d4a6e4002265697a59
Author: tengqm <email address hidden>
Date: Thu Apr 3 04:44:40 2014 +0800

    Fix status reason in events for deployment signals

    When a signal is received and processed by a Resource, there could be an
    event generated automatically. For such an event, Heat is supposed to
    provide some useful message (including status_reason). But currently,
    the resource code can only process ceilometer alarms and watch rules,
    for signals sent for a SoftwareDeployment resource, the signal is only
    providing an string 'Unknown' as the status change reason. This is
    confusing when a user performs 'heat event-list stack'.

    This patch adds an additional check (guess) whether the signal comes
    from a SoftwareDeployment. If that is the case, fill in the status
    reason as 'deployment succeeded', or 'deployment failed (n)', where n is
    the deploy_status_code that comes with the signal.

    Closes-Bug: #1300679
    Change-Id: Ic970a5dac923fffdcdd365983df58f4d338de849