Ubuntu UI Toolkit

Cannot use visible property reliably while using Ubuntu Layouts

Bug #1300668 reported by Nekhelesh Ramananthan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Critical
Zsombor Egri
Ubuntu UI Toolkit june-2014
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

Ubuntu Layout manipulates the "visible" property to hide and show things when switching from one layout to the other. However if the app developer also relies on manipulating the "visibility" property to perform certain tasks such as showing an item only when a certain condition is met and so on, that no longer works since Ubuntu Layouts is changing the visible property values resulting in items being shown incorrectly.

Ubuntu Layouts should do its function without affecting the original functionality implemented by the app developer.

Flashback (3rd Party App) is affected by this bug while switching tabs. See the video at https://www.youtube.com/watch?v=kR-ZkZ9ZOjA illustrating the bug.

See original description

Related branches

lp:~zsombi/ubuntu-ui-toolkit/layouts-visibility
Cris Dywan: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 1516 lines (+595/-227)
12 files modified
components.api (+2/-0)
modules/Ubuntu/Layouts/plugin/plugin.pro (+1/-1)
modules/Ubuntu/Layouts/plugin/propertychanges.cpp (+18/-33)
modules/Ubuntu/Layouts/plugin/propertychanges_p.h (+3/-16)
modules/Ubuntu/Layouts/plugin/ulitemlayout.h (+4/-1)
modules/Ubuntu/Layouts/plugin/ullayouts.cpp (+92/-81)
modules/Ubuntu/Layouts/plugin/ullayouts.h (+8/-3)
modules/Ubuntu/Layouts/plugin/ullayouts_p.h (+3/-5)
tests/unit_x11/tst_layouts/NestedVisibility.qml (+163/-0)
tests/unit_x11/tst_layouts/Visibility.qml (+84/-0)
tests/unit_x11/tst_layouts/tst_layouts.cpp (+214/-86)
tests/unit_x11/tst_layouts/tst_layouts.pro (+3/-1)
Nekhelesh Ramananthan (nik90)
tags: added: convergence layouts
Revision history for this message
Zsombor Egri (zsombi) wrote :

As a workaround use opacity to hide/show your component.

Changed in ubuntu-ui-toolkit:
milestone: none → april-2014
assignee: nobody → Zsombor Egri (zsombi)
status: New → Confirmed
importance: Undecided → High
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: High → Critical
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

11:08 AM <nik90> zsombi: I added a onVisibleChanged function there and I notice that the items in the default layout change from true to false when switching from phone to tablet layout. But when the bug appears, the visible property is still false and doesn't change to true when going back to the default layout.
11:08 AM <zsombi> nik90: hmm... ok... that's bad then :/ The issue with the Tab changing caused default layout screwup might be caused by the Tab switch visibility handling...

description: updated
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
milestone: april-2014 → june-2014
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.