BigSwitch ML2 driver uses portbindingsports table

Bug #1300628 reported by Kevin Benton
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton

Bug Description

The Big Switch ML2 driver references the deprecated portbindings_db in the port location tracking code. This needs to be removed because it's resulting in the entire portbinding_db schema for one small function.

Tags: bigswitch ml2
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84377

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
tags: added: bigswitch
Robert Kukura (rkukura)
tags: added: icehouse-rc-potential ml2
tags: added: icehouse-backport-potential
removed: icehouse-rc-potential
Changed in neutron:
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/84377
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c70c2719d700902854ef0381cb725722ac2da05e
Submitter: Jenkins
Branch: master

commit c70c2719d700902854ef0381cb725722ac2da05e
Author: Kevin Benton <email address hidden>
Date: Tue Apr 1 01:05:29 2014 -0700

    Stop using portbindings_db in BSN ML2 driver

    Avoids using the portbindings_db in the Big Switch
    ML2 driver since ML2 has deprecated that database for
    its own version that tracks the same information.

    Also eliminates unnecessary 'binding_host' field since
    it is now always the same as as the 'portbinding:host_id'
    field.

    Closes-Bug: #1300628
    Change-Id: I17d47cb446cdd2e989c3e0d01b797a81309faaa7

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84983

tags: removed: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/84983
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1997cc97f14b95251ad568820160405e34a39801
Submitter: Jenkins
Branch: master

commit 1997cc97f14b95251ad568820160405e34a39801
Author: Kevin Benton <email address hidden>
Date: Thu Apr 3 10:00:37 2014 +0000

    BigSwitch: Don't import portbindings_db until use

    The Big Switch ML2 driver re-uses large parts of
    code from the Big Switch plugin. However, the plugin
    uses the old portbindings_db in its port tracking
    code. This db is not created/used by ML2, so it does
    not exist when the Big Switch ML2 driver is being used.
    This caused a problem when the portbindings_db module
    would be imported even though it wasn't being used
    since the SQLAlchemy models would create the
    relationships during the import.

    This patch moves the portbindings_db import down to
    the methods that leverage it so it won't be imported
    during use by the ML2 driver.

    This is a temporary solution which can be back-ported
    if disabling auto schema generation is back-ported
    to icehouse. An appropriate fix will require some
    refactoring to avoid the port tracking code from
    being imported for ML2.

    Closes-Bug: #1300628
    Change-Id: I551abf9d6ec832c423cba0d50bb27715b43c0b1c

no longer affects: neutron/icehouse
Changed in neutron:
milestone: juno-1 → icehouse-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (milestone-proposed)

Reviewed: https://review.openstack.org/85517
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f367d7422c669fda908b5ef0228cde9dc5717f63
Submitter: Jenkins
Branch: milestone-proposed

commit f367d7422c669fda908b5ef0228cde9dc5717f63
Author: Kevin Benton <email address hidden>
Date: Tue Apr 1 01:05:29 2014 -0700

    Stop using portbindings_db in BSN ML2 driver

    Avoids using the portbindings_db in the Big Switch
    ML2 driver since ML2 has deprecated that database for
    its own version that tracks the same information.

    Also eliminates unnecessary 'binding_host' field since
    it is now always the same as as the 'portbinding:host_id'
    field.

    Closes-Bug: #1300628
    Change-Id: I17d47cb446cdd2e989c3e0d01b797a81309faaa7
    (cherry picked from commit c70c2719d700902854ef0381cb725722ac2da05e)

Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.