Fuel CI job for fuel-web ignores Nailgun test failures
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Released
|
Critical
|
Dmitry Borodaenko |
Bug Description
Running the following test case manually like this:
nosetests nailgun/
on fuel-web master currently gets you the following error:
Traceback (most recent call last):
File "/home/
self.
AttributeError: 'TestTaskHandlers' object has no attribute 'env'
Bisecting shows that this was broken by https:/
The problem is, that review has +1 from Fuel CI, so it was reasonable for developers and reviewers to assume that unit tests passed.
However, if you look into console log of that Fuel CI job (https:/
test_forced_
And yet, that error ended up being ignored by the test script and it proceeded to run UI and Flake8 tests and ultimately reported success.
tags: | added: backports-4.1.1 |
Changed in fuel: | |
status: | Fix Committed → In Progress |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
milestone: | 5.0 → 4.1.1 |
tags: | removed: system-tests |
Changed in fuel: | |
status: | In Progress → Fix Committed |
Changed in fuel: | |
status: | Fix Committed → Fix Released |
The original root cause is "| tee" in the following line: /github. com/stackforge/ fuel-web/ blob/64b5e4ef55 2a00c81ec74567d f3657a4249ac145 /run_tests. sh#L187
https:/
This causes the "tee" exit code to overwrite exit code of nosetests, so run_nailgun_tests() never returns error.