Fix ugly view for shell response on security-group list for instances that has more than one rule

Bug #1300164 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
Fix Released
Low
Denis M.

Bug Description

+----+-----------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------+
| id | name | rules | instance_id |
+----+-----------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------+
| 2 | SecGroup_81cce066-41ae-4142-9bcd-61cdc80058de | [{u'to_port': 7001, u'cidr': u'0.0.0.0/0', u'from_port': 7001, u'protocol': u'tcp', u'id': u'1'}, {u'to_port': 7000, u'cidr': u'0.0.0.0/0', u'from_port': 7000, u'protocol': u'tcp', u'id': u'2'}, {u'to_port': 9160, u'cidr': u'0.0.0.0/0', u'from_port': 9160, u'protocol': u'tcp', u'id': u'3'}, {u'to_port': 9042, u'cidr': u'0.0.0.0/0', u'from_port': 9042, u'protocol': u'tcp', u'id': u'4'}] | 81cce066-41ae-4142-9bcd-61cdc80058de |
+----+-----------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------------------+

Was made a certain decision to add next command:
trove secgroup-list-rules <secgroup-id>

This would change would allow to avoid security group rules sub-formatting inside "trove secgroup-list"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/85314

Changed in python-troveclient:
assignee: nobody → Denis M. (dmakogon)
status: New → In Progress
Denis M. (dmakogon)
description: updated
description: updated
Changed in python-troveclient:
importance: Undecided → Low
milestone: none → juno-1
milestone: juno-1 → none
Denis M. (dmakogon)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/85314
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=b8fa51d9d04f56a593498afd06c4954d2ba99fb0
Submitter: Jenkins
Branch: master

commit b8fa51d9d04f56a593498afd06c4954d2ba99fb0
Author: Denis Makogon <email address hidden>
Date: Thu Jun 12 13:38:30 2014 +0300

    Fix shell view for secgroup-* commands

    Reasons:
     - currect code writes list of dict as they are,
       without any formatting, actually _print_
       method calls str() on each attribute,
       this issue spoils human-readable form of the shell output.

    Changes:
     - updated "secgroup-list" (`rules` attributes was ignored);
     - updated "secgroup-show" (`rules` attribute was ripped off);
     - proposed new call "secgroup-list-rules <secgroup-id>";

    Change-Id: Ic3f51b93af106c39de7eb3238f8bcffa3ea3cb95
    Closes-Bug: #1300164
    DocImpact: added new CLI command.

Changed in python-troveclient:
status: In Progress → Fix Committed
Changed in python-troveclient:
milestone: none → 1.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.