template migration fails if version is integer

Bug #1299174 reported by Vijendar Komalla
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steven Dake

Bug Description

In the patch https://review.openstack.org/#/c/83241/ template migration script 043_migrate_template_versions.py assumes that template version would be a string. But it could be a non string value.
For example, it was observed that when the version was an integer value, DB migration was failing with 'TypeError' at
https://github.com/openstack/heat/blob/master/heat/db/sqlalchemy/migrate_repo/versions/043_migrate_template_versions.py#L46

description: updated
description: updated
Steven Dake (sdake)
Changed in heat:
milestone: none → icehouse-rc1
importance: Undecided → High
assignee: nobody → Steven Dake (sdake)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83869

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/83869
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f91569de61e6b91a2d6288c5f06f12d65946d80d
Submitter: Jenkins
Branch: master

commit f91569de61e6b91a2d6288c5f06f12d65946d80d
Author: Steven Dake <email address hidden>
Date: Fri Mar 28 12:29:26 2014 -0700

    version migration fails if version is an integer

    The migration 043 fails to account for the case where the version
    was specified as a string or version contains non-ascii characters.
    This breaks migration for folks that have those incorrect templatesx
     in their database.

    Change-Id: I9c2143c9d7a4d61ff41d32ee0f7b12a5640eec72
    Closes-bug: 1299174

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.