Current trunk 6898 does not compile on win32

[Tino]

The refactoring 6895 broke win32.
I was able to find at least one bug (return -1 while the function's return changed to std::str), but while it compiles now and Widelands starts, only the menus are shown.
No sounds and when you start a game, the grafics are missing (black screen)

[SirVer (sirver)]

sorry for breaking the build :(

Why did you change if (hfile == -1) to if (hfile) ? that is a semantic change for sure.

I have reasons to believe that the regression is also in this very function that you fixed. I merged your branch and added a bunch of debugging output. I guess this will help to track down the problem. Could you attach a stderr.txt from a run?

[Tino (tino79)]

Ok, current status: It does compile again.
But still does not run, stdout.txt:
 Set home directory: C:\Users\mit\.widelands
 No version file found
 Adding directory: c:\data\bzr\widelands\trunk
 No version file found
 selected language: (system language)
 #sirver realpath: replays\,c_file: .
 #sirver filename: C:\Users\mit\.widelands\replays
 #sirver result: replays
 #sirver realpath: replays\,c_file: ..
 #sirver filename: C:\Users\mit\.widelands

stderr.txt:
 Caught exception (of type 'St12out_of_range') in outermost handler!
 The exception said: basic_string::substr

 This should not happen. Please file a bug report on version bzr6901[trunk](Release).
 and remember to specify your operating system.

Will have to investigate tomorrow...

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.