"heat stack-abandon" should have a default output file

Bug #1299023 reported by Edmund Troche
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
Medium
Masahito Muroi

Bug Description

When using the stack abandon I find that not having a default output file to hold the state makes this a dangerous operation. If the user prematurely issues the command without redirecting the output of "heat stack-abandon" to a file then they loose the state information, and there is no other way to recover it. This command should have something akin to a "-o" option to specify the name of the output file, with a default when not specified (e.g. if we issue "heat stack-abandon test-stack", and did not specify an output file with "-o", then produce a file "test-stack.state", or something to that effect"). The option to output to standard out may be useful, so maybe we still want to have a way to tell this command to output to stdout (e.g. a file name "-" for "-o"?).

JunJie Nan (nanjj)
affects: heat → python-heatclient
Changed in python-heatclient:
importance: Undecided → Medium
milestone: none → v0.2.9
Changed in python-heatclient:
status: New → Triaged
milestone: v0.2.9 → none
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Is this still valid? Stack-abandon prints to stdout by default (https://github.com/openstack/python-heatclient/blob/master/heatclient/v1/shell.py#L262), so if user has forgot to redirect the output (s)he is still able to copy-paste from terminal.

Changed in python-heatclient:
assignee: nobody → Masahito Muroi (muroi-masahito)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/96690

Changed in python-heatclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/96690
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=f826bd612e514b1ba29d5f8e5e64a64fb5a83fd3
Submitter: Jenkins
Branch: master

commit f826bd612e514b1ba29d5f8e5e64a64fb5a83fd3
Author: Masahito Muroi <email address hidden>
Date: Sat May 31 02:26:43 2014 +0900

    output-file option in stack-abandon

    This patch adds --output-file, -O option in stack-abandon command.
    If the option is specified, stack-abandon will output a result into
     the file.

    Change-Id: Ic2518eae86d5f917d5227c6ab73062b665b5a89b
    Closes-Bug: #1299023

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
milestone: none → v0.2.11
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.