bootresources.yaml contains "selections: null"

[Raphaël Badin]

After installing the daily package, /etc/maas/bootresources.yaml contains the following configuration:

# <lots of comments>
boot:
  sources:
  - keyring: /usr/share/keyrings/ubuntu-cloudimage-keyring.gpg
    path: http://maas.ubuntu.com/images/ephemeral-v2/daily/
    selections: null
  storage: /var/lib/maas/boot-resources/

Looks related to the config-rewriting code that landed recently.

The result is that *all* the images published in http://maas.ubuntu.com/images/ephemeral-v2/daily/ are downloaded.

[Julian Edwards (julian-edwards)]

I think I found the source of the bug. This code is wrong:

def rewrite_boot_resources_config(config_file):
    """Rewrite the `bootresources.yaml` configuration.

    Supports the `generate_boot_resources_config` upgrade hook.
    """
    tftproot = Config.load_from_cache()['tftp']['root']

tftproot ends up pointing at the *new* tftp area rather than the old one. This is because the default tftp "root" config on pserv.yaml is commented out so it comes from the default schema value which has been updated to the new area.

This highlights a second problem; if someone altered their tftp root and configured it in pserv.yaml, the new boot resources will not be found.

[Julian Edwards (julian-edwards)]

Actually that is a separate bug! I can confirm that when I set tftp root to the old area in pserv.yaml that I see my existing selections wiped out and replaced with:

    selections: null

[Julian Edwards (julian-edwards)]

I filed it as bug 1298714