seamicro.vendor_passthru.validate has broken method definition

Bug #1298648 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
aeva black

Bug Description

If the python-seamicroclient library is installed and unit tests are run, the seamicro unit tests will fail with

TypeError: validate() takes exactly 2 arguments (4 given)

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83598

Changed in ironic:
assignee: nobody → Devananda van der Veen (devananda)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/83598
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3477ad215ea40618413bf8964af995014d5022da
Submitter: Jenkins
Branch: master

commit 3477ad215ea40618413bf8964af995014d5022da
Author: Devananda van der Veen <email address hidden>
Date: Thu Mar 27 14:30:10 2014 -0700

    Fix seamicro validate() method definition

    The base class definition of vendor_passthru.validate() was changed
    in 48a4223f so that it also required a 'task' parameter, but
    the seamicro.vendor_passthru driver had not landed yet. Between that
    change and the time the seamicro driver was landed, another change
    caused us to stop running unit tests on third-party drivers.

    So, we didn't notice that the seamicro.vendor_passthru.validate() method
    definition was incompatibly broken.

    Closes-bug: #1298648

    Change-Id: I9eab4c1d1be0546a0cdbf40759e88bb22f5015d2

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.