generator should sanitize options ending with the fqdn of the machine

Bug #1298589 reported by Gauvain Pocentek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Medium
Gauvain Pocentek

Bug Description

We use the generator._sanitize_default() method in the openstack-doc-tools package to generate the configuration tables for the config-reference. The neutron_id option (and only this one for now) uses the machine fqdn to generate an id. Sanitizing such values could avoid ending up with "neutron-your.fqdn.here" in the sample files and in documentation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83571

Changed in oslo:
assignee: nobody → Gauvain Pocentek (gpocentek)
status: New → In Progress
Ben Nemec (bnemec)
Changed in oslo:
importance: Undecided → Medium
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/83571
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=7f307c27697f3e622dd22f108edbeeed22e0f482
Submitter: Jenkins
Branch: master

commit 7f307c27697f3e622dd22f108edbeeed22e0f482
Author: Gauvain Pocentek <email address hidden>
Date: Fri Apr 4 08:41:37 2014 +0200

    generator: sanitize values ending with the fqdn

    Some options (neutron_id in the neutron bigswitch plugin) use the
    hostname/fqdn to generate default values prefixed with a static string.
    This patch handles such options and sanitize the default value by
    replacing the hostname/fqdn with the 'oslo' string.

    Closes-Bug: #1298589
    Change-Id: I2471d638f42fc425efc928b280e1b47c23fddabd

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → juno-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.