pep8: threading.py and log.py failed
Bug #1298551 reported by
Trevor Vardeman
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| oslo-incubator |
Fix Released
|
Low
|
Trevor Vardeman | ||
Bug Description
Running pep8 with the following command in the base directory of oslo-incubator:
$ pep8 `find . -iname "*.py" | grep -v ".*/.tox/.*"`
yields the following results:
./openstack/
./openstack/
| Changed in oslo: | |
| assignee: | nobody → Trevor Vardeman (trevor-vardeman) |
| Changed in oslo: | |
| status: | New → Won't Fix |
Revision history for this message
| Ben Nemec (bnemec) wrote | #1 |
| Changed in oslo: | |
| status: | Won't Fix → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to oslo-incubator (master) | #2 |
| Changed in oslo: | |
| status: | Triaged → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to oslo-incubator (master) | #3 |
| Changed in oslo: | |
| status: | In Progress → Fix Committed |
| Changed in oslo: | |
| milestone: | none → juno-1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is because we use a variation on pep8, including flake8 with some custom rules we've written in the hacking project. I don't think we expect plain pep8 to pass.
Although actually on second thought, I think we could remove the #noqa from the long line and it would get it under 80 chars. I'm not sure why that's there. I'll reopen this and you can fix that if you want.
Note that the way we run style checks is "tox -e pep8" (poorly named for historical reasons). Those are the rules we enforce in the gate.