If volume copy not finished, user add a copy of the volume, storwize/svc driver will failed

[Li Min Liu]

2014-03-27 14:22:13.716 ERROR cinder.volume.drivers.san.san [req-ef2dc69d-74f5-4551-b4bd-74ec725f0390 08328d4607504beda2c6bb189b879ba6 c9c4178
0fac445b3b6e9a1ff2c805d8d] Error running SSH command: svctask addvdiskcopy -rsize 2% -autoexpand -warning 20% -grainsize 256 -easytier on -mdi
skgrp Anna_Test volume-a9b15c37-f70f-4a47-8f29-101d7e3970ef
2014-03-27 14:22:13.717 ERROR cinder.volume.drivers.ibm.storwize_svc.ssh [req-ef2dc69d-74f5-4551-b4bd-74ec725f0390 08328d4607504beda2c6bb189b8
79ba6 c9c41780fac445b3b6e9a1ff2c805d8d] CLI Exception output:
 command: ['svctask', 'addvdiskcopy', '-rsize', '2%', '-autoexpand', '-warning', '20%', '-grainsize', '256', '-easytier', 'on', '-mdiskgrp', u
'Anna_Test', u'volume-a9b15c37-f70f-4a47-8f29-101d7e3970ef']
 stdout:
 stderr: CMMVC6352E The command failed because the number of copies of this virtual disk (VDisk) would exceed the limit.

2014-03-27 14:22:13.718 ERROR cinder.volume.manager [req-ef2dc69d-74f5-4551-b4bd-74ec725f0390 08328d4607504beda2c6bb189b879ba6 c9c41780fac445b3b6e9a1ff2c805d8d] Volume a9b15c37-f70f-4a47-8f29-101d7e3970ef: driver error when trying to retype, falling back to generic mechanism.
2014-03-27 14:22:13.719 ERROR cinder.volume.manager [req-ef2dc69d-74f5-4551-b4bd-74ec725f0390 08328d4607504beda2c6bb189b879ba6 c9c41780fac445b3b6e9a1ff2c805d8d] Bad or unexpected response from the storage volume backend API: CLI Exception output:
 command: ['svctask', 'addvdiskcopy', '-rsize', '2%', '-autoexpand', '-warning', '20%', '-grainsize', '256', '-easytier', 'on', '-mdiskgrp', u'Anna_Test', u'volume-a9b15c37-f70f-4a47-8f29-101d7e3970ef']
 stdout:
 stderr: CMMVC6352E The command failed because the number of copies of this virtual disk (VDisk) would exceed the limit.

2014-03-27 14:22:13.719 TRACE cinder.volume.manager Traceback (most recent call last):
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1232, in retype
2014-03-27 14:22:13.719 TRACE cinder.volume.manager diff, host)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/__init__.py", line 734, in retype
2014-03-27 14:22:13.719 TRACE cinder.volume.manager self.configuration)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/helpers.py", line 703, in add_vdisk_copy
2014-03-27 14:22:13.719 TRACE cinder.volume.manager new_copy_id = self.ssh.addvdiskcopy(vdisk, dest_pool, params)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/ssh.py", line 304, in addvdiskcopy
2014-03-27 14:22:13.719 TRACE cinder.volume.manager return self.run_ssh_check_created(ssh_cmd)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/ssh.py", line 60, in run_ssh_check_created
2014-03-27 14:22:13.719 TRACE cinder.volume.manager out, err = self._run_ssh(ssh_cmd)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/ibm/storwize_svc/ssh.py", line 41, in _run_ssh
2014-03-27 14:22:13.719 TRACE cinder.volume.manager raise exception.VolumeBackendAPIException(data=msg)
2014-03-27 14:22:13.719 TRACE cinder.volume.manager VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: CLI Exception output:
2014-03-27 14:22:13.719 TRACE cinder.volume.manager command: ['svctask', 'addvdiskcopy', '-rsize', '2%', '-autoexpand', '-warning', '20%', '-grainsize', '256', '-easytier', 'on', '-mdiskgrp', u'Anna_Test', u'volume-a9b15c37-f70f-4a47-8f29-101d7e3970ef']

[Li Min Liu (liminliu)]

depend on https://review.openstack.org/#/c/84991/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/86782

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/86782
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=24eb8234ff4b907b8c88f26fb0c427cb7a452140
Submitter: Jenkins
Branch: master

commit 24eb8234ff4b907b8c88f26fb0c427cb7a452140
Author: Li Min Liu <email address hidden>
Date: Fri Apr 11 10:50:24 2014 +0800

    Add exception catch if Storwize/SVC driver failed when
    retyping

    If adding a copy for a volume of Storwize/SVC which is under
    migration, Storwize/SVC command will fail because the
    number of the copies of the volume exceed the limit which
    is 2.

    Modifying the volume type when adding a copy for the volume,
    Storwize/SVC driver will also fail, should add exception catch.

    Also add exception catch when getting the volume from the database.
    This change is necessary to enable resolving bug 1305550
    (https://bugs.launchpad.net/cinder/+bug/1305550 - Failed retype with
    driver raised exception should set volume status to "error" ).

    Change-Id: I1cf4b6606b5228c8adcb2bde21f345fa979bc13e
    Closes-Bug: #1298201

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/89559

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/89559
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d17277d37d41072b113738d95c0a3bf3a6ab2549
Submitter: Jenkins
Branch: stable/icehouse

commit d17277d37d41072b113738d95c0a3bf3a6ab2549
Author: Li Min Liu <email address hidden>
Date: Fri Apr 11 10:50:24 2014 +0800

    Add exception catch if Storwize/SVC driver failed when
    retyping

    If adding a copy for a volume of Storwize/SVC which is under
    migration, Storwize/SVC command will fail because the
    number of the copies of the volume exceed the limit which
    is 2.

    Modifying the volume type when adding a copy for the volume,
    Storwize/SVC driver will also fail, should add exception catch.

    Also add exception catch when getting the volume from the database.
    This change is necessary to enable resolving bug 1305550
    (https://bugs.launchpad.net/cinder/+bug/1305550 - Failed retype with
    driver raised exception should set volume status to "error" ).

    Change-Id: I1cf4b6606b5228c8adcb2bde21f345fa979bc13e
    Closes-Bug: #1298201
    (cherry picked from commit 24eb8234ff4b907b8c88f26fb0c427cb7a452140)