neutron::agents::ovs fails unless service and package are enabled/present

[Xav Paice]

Under some (rare) circumstances it is desired to declare the neutron::agents::ovs class without enabling the service or even installing the package. This allows the configuration necessary to allow a default security group to be configured and used. Without declaring the class on the server running neutron-server, default security groups are not configured. The service neutron-plugin-ovs-service is not required on the same server as neutron-server, even though the actual ovs-plugin uses the same configuration file.

If the class is called with enabled => false, and package_ensure => absent, the class fails to run due to dependencies on Service['neutron-plugin-ovs-service'].

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/83274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/83274
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=eecad5cb1b3802bffc2c6431f82436d971a62d7a
Submitter: Jenkins
Branch: master

commit eecad5cb1b3802bffc2c6431f82436d971a62d7a
Author: Xav Paice <email address hidden>
Date: Thu Mar 27 15:17:25 2014 +1300

    allow neutron::agents::ovs without package install

    This alters the service notification and dependency behaviour for
    neutron::agents::ovs such that if the package is not installed (i.e.
    package_ensure => absent, enabled => false) the class still runs without
    producing errors. This is to allow the generation of config files
    without needing to install the package in the first place.

    Change-Id: I027313518f778d58e6e19b9b933ff17c0094a8aa
    Closes-Bug: #1298146