Glance Tests Will Fail With psutil 2.0.0

[Solly Ross]

psutil recently released a new version in which the majorly broke API backwards-compatibility. Currently, the requirement for psutil is 'psutil>=1.1.1'. We should limit the psutil version to 'psutil>=1.1.1,<2.0.0' so as to not break the multiprocessing tests, which use psutil.

[Zhi Yan Liu (lzy-dev)]

I can't reproduce situation you mentioned in my local development environment. Please provide more information, like log, exception stack and etc.

lzy@dev-controller-master:~/workspace/openstack-org/glance$ tools/with_venv.sh python
Python 2.7.3 (default, Feb 27 2014, 19:58:35)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import psutil
>>> psutil.__file__
'/home/lzy/workspace/openstack-org/glance/.venv/local/lib/python2.7/site-packages/psutil/__init__.pyc'
>>> import pkg_resources
>>> pkg_resources.get_distribution("psutil").version
'2.0.0'
>>> exit()

lzy@dev-controller-master:~/workspace/openstack-org/glance$ ./run_tests.sh glance.tests.functional.v1.test_multiprocessing
Running `tools/with_venv.sh python -m glance.openstack.common.lockutils python setup.py testr --testr-args='--subunit --concurrency 1 glance.tests.functional.v1.test_multiprocessing'`
glance.tests.functional.v1.test_multiprocessing.TestMultiprocessing
    test_interrupt_avoids_respawn_storm OK 5.14
    test_multiprocessing OK 2.27

Slowest 2 tests took 7.41 secs:
glance.tests.functional.v1.test_multiprocessing.TestMultiprocessing
    test_interrupt_avoids_respawn_storm 5.14
    test_multiprocessing 2.27

Ran 2 tests in 10.933s

OK

[Solly Ross (sross-7)]

It would appear that the author left some of the old methods in place as deprecated versions without actually documenting that, while others he just removed. It would appear the ones that glance uses are still in place in 2.0.0, although there's no indication as to when that will change (especially since they no longer appear in the documentation). Sorry about any confusion there (I could have sworn the same method broke in similar code I had elsewhere...).

[Solly Ross (sross-7)]

I still think it's important to limit psutil to <2.0.0 -- we shouldn't be using undocumented methods that have no indication as to when they will disappear

[Erno Kuvaja (jokke)]

Proposed fix Merged 35b806893401ea1e0fca29a2f51470df590af52d