Nova ironic driver ignores the "swap" field from flavor

Bug #1297937 reported by Lucas Alvares Gomes
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Critical
Lucas Alvares Gomes

Bug Description

The nova Ironic driver should look at the swap field in the flavor and map it to Ironic, just like it does with the disk size[1]

[1] https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/ironic_driver_fields.py#L40-L43

Changed in ironic:
importance: Undecided → Medium
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83131

Changed in ironic:
status: New → In Progress
aeva black (tenbrae)
Changed in ironic:
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/83131
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a244d1bc7b67c13db31de4830036a7829906655e
Submitter: Jenkins
Branch: master

commit a244d1bc7b67c13db31de4830036a7829906655e
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Mar 26 16:45:42 2014 +0000

    Nova Ironic driver to set pxe_swap_mb in Ironic

    This patch fix the Nova Ironic driver to make it look at the swap field
    in the flavor and map it to Ironic as driver_info/pxe_swap_mb.

    Change-Id: Ic6091fd6b6c8e1a32a33969ce5cdd20f6c243167
    Closes-Bug: #1297937

Changed in ironic:
status: In Progress → Fix Committed
aeva black (tenbrae)
Changed in ironic:
status: Fix Committed → In Progress
Revision history for this message
aeva black (tenbrae) wrote :

Bumping this to critical since the fix broke all deployments.

A second fix has been proposed at:
  https://review.openstack.org/#/c/84167/

Changed in ironic:
importance: Medium → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/84167
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8e809a68910d1a193e209f01c83e6537add3039d
Submitter: Jenkins
Branch: master

commit 8e809a68910d1a193e209f01c83e6537add3039d
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Mar 31 17:18:41 2014 +0100

    If no swap is specified default to 1MB

    After a244d1bc7b the Nova Ironic Driver will add the pxe_swap_mb parameter
    using the value in the flavor (which defaults to 0 if not specified). In
    the Ironic code we had something like get('pxe_swap_mb', 1) to prevent
    the swap size for being 0, but that get() won't work anymore because the
    pxe_swap_mb is set. So this patch is taking another approach to force
    the the pxe_swap_mb parameter to be > 0.

    Related-Bug: #1297937
    Change-Id: Ie124f58681fc184950918cde1bc8c565c1387fc8

aeva black (tenbrae)
Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.