some tests call "called_once_with_args" with no assert, those lines are ignored
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Medium
|
Miguel Angel Ajo |
Bug Description
A few tests use "called_
without checking the result.
That means that we're not asserting for that to happen.
Those tests need to be fixed.
[majopela@
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
Changed in neutron: | |
assignee: | nobody → Miguel Angel Ajo (mangelajo) |
status: | New → In Progress |
Changed in neutron: | |
importance: | Undecided → Medium |
tags: | added: icehouse-backport-potential unittest |
Changed in neutron: | |
milestone: | none → juno-1 |
tags: | removed: icehouse-backport-potential |
no longer affects: | neutron/icehouse |
Changed in neutron: | |
milestone: | juno-1 → icehouse-rc2 |
Changed in neutron: | |
milestone: | icehouse-rc2 → 2014.1 |
There are a few ".called_once()" too.
[majopela@ f20-devstack neutron]$ grep ".called_once" * -R | grep -v assert tests/unit/ test_agent_ netns_cleanup. pyc matches tests/unit/ agent/linux/ test_async_ process. py: mock_kill. called_ once() tests/unit/ openvswitch/ test_ovs_ neutron_ agent.py: mock_loop. called_ once()
Binary file neutron/
neutron/
neutron/