Sahara

A number of places where RuntimeError is incorrectly raise

Bug #1296990 reported by Andrew Lazarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Andrew Lazarev
Sahara 2014.1 "icehouse"

Bug Description

I see a number of places where "raise RuntimeError(message, params, cause)" construction is used. RuntimeError doesn't format message with arguments like e.g. loggers do. All such places need to be replaced with "raise RuntimeError(message % params, cause)" unless RuntimeError is not replaced with the specific one.

Andrew Lazarev (alazarev)
summary: - A lot of places where RuntimeError is incorrectly raise
+ A number of places where RuntimeError is incorrectly raise
Andrew Lazarev (alazarev)
Changed in sahara:
assignee: nobody → Andrew Lazarev (alazarev)
Sergey Lukjanov (slukjanov)
Changed in sahara:
milestone: none → icehouse-rc1
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Sergey Lukjanov (slukjanov) wrote :

https://review.openstack.org/#/c/82651/

Changed in sahara:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/82651
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=3b0e41c922f8f90d99eb1bc226b356a59ec8ab5b
Submitter: Jenkins
Branch: master

commit 3b0e41c922f8f90d99eb1bc226b356a59ec8ab5b
Author: Andrew Lazarev <email address hidden>
Date: Mon Mar 24 15:58:44 2014 -0700

    Fixed incorrect use of RuntimeError

    Change-Id: Ia1cd3e23410c64fe1f557586e24776c594b8cfb7
    Closes-Bug: #1296990

Changed in sahara:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.